Discussion:
handling query strings with ? in
(too old to reply)
Michael Stevens
2013-05-13 12:05:37 UTC
Permalink
Hi,

I tried to apply the patch to Embperl 2.5.0_4, but I got the following
error when building:

epinit.c: In function ‘embperl_GetFormData’:
epinit.c:1029: error: ‘false’ undeclared (first use in this function)
epinit.c:1029: error: (Each undeclared identifier is reported only once
epinit.c:1029: error: for each function it appears in.)
epinit.c:1165: error: ‘true’ undeclared (first use in this function)
make: *** [epinit.o] Error 1
Hi Michael,****
** **
the following patch should fix your problem:****
** **
http://svn.apache.org/viewvc/perl/embperl/trunk/epinit.c?r1=1382642&r2=1481318
****
** **
Regards****
** **
Gerald****
** **
---****
Tel. +49 (6133) 939 122****
** **
*Von:* Gerald Richter - ECOS
*Gesendet:* Freitag, 3. Mai 2013 15:41
*An:* Michael Stevens
*Betreff:* AW: handling query strings with ? in****
** **
Ok, I try to fix it during the next days****
** **
Gerald****
** **
*Gesendet:* Freitag, 3. Mai 2013 15:38
*An:* Gerald Richter
*Betreff:* Re: handling query strings with ? in****
** **
Yes, I think the CGI.pm behaviour is good, and would like it if Embperl
was the same.****
** **
Is there anything that can be done to make embperl behave more as
expected?****
****
What is what you would expect? I think the way CGI.pm is correct regarding
the specs. Is that what you would expect?****
****
Gerald****
****
****
*Gesendet:* Freitag, 3. Mai 2013 15:05
*Betreff:* handling query strings with ? in****
****
Hi.****
****
We're trying to handle some odd query strings in embperl, eg:****
****
http://www.example.com/mjs/q.epl?a=b?c=d
****
****
embperl parses this as:****
****
Using %fdat****
Field****
Value****
a b?c****
d****
****
CGI.pm parses this as:****
****
Using CGI.pm****
Field****
Value****
a****
b?c=d****
****
I agree that these are some pretty bizarre queries, but annoyingly we
can't change the source, and embperl seems to handle them pretty badly.
Googling suggests ? in a query string is probably valid, eg:****
****
http://www.456bereastreet.com/archive/201008/what_characters_are_allowed_unencoded_in_query_strings/
****
****
Is there anything that can be done to make embperl behave more as expected?
****
****
-- ****
Michael Stevens****
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB
Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com
The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988 ****
****
** **
--
Michael Stevens****
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB
Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com
The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988 ****
--
Michael Stevens
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB

Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com

The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988
Michael Stevens
2013-05-13 12:09:58 UTC
Permalink
Thanks, that builds. We will test.
Ok, just replace false with 0 and true with 1, then it should work (sorry
I used a newer compiler)****
** **
Gerald****
** **
*Gesendet:* Montag, 13. Mai 2013 14:06
*An:* Gerald Richter
*Betreff:* Re: handling query strings with ? in****
** **
Hi,****
** **
I tried to apply the patch to Embperl 2.5.0_4, but I got the following
error when building:****
** **
epinit.c: In function ‘embperl_GetFormData’:****
epinit.c:1029: error: ‘false’ undeclared (first use in this function)****
epinit.c:1029: error: (Each undeclared identifier is reported only once***
*
epinit.c:1029: error: for each function it appears in.)****
epinit.c:1165: error: ‘true’ undeclared (first use in this function)****
make: *** [epinit.o] Error 1****
** **
** **
Hi Michael,****
****
the following patch should fix your problem:****
****
http://svn.apache.org/viewvc/perl/embperl/trunk/epinit.c?r1=1382642&r2=1481318
****
****
Regards****
****
Gerald****
****
---****
Tel. +49 (6133) 939 122****
****
*Von:* Gerald Richter - ECOS
*Gesendet:* Freitag, 3. Mai 2013 15:41
*An:* Michael Stevens
*Betreff:* AW: handling query strings with ? in****
****
Ok, I try to fix it during the next days****
****
Gerald****
****
*Gesendet:* Freitag, 3. Mai 2013 15:38
*An:* Gerald Richter
*Betreff:* Re: handling query strings with ? in****
****
Yes, I think the CGI.pm behaviour is good, and would like it if Embperl
was the same.****
****
Is there anything that can be done to make embperl behave more as
expected?****
****
What is what you would expect? I think the way CGI.pm is correct regarding
the specs. Is that what you would expect?****
****
Gerald****
****
****
*Gesendet:* Freitag, 3. Mai 2013 15:05
*Betreff:* handling query strings with ? in****
****
Hi.****
****
We're trying to handle some odd query strings in embperl, eg:****
****
http://www.example.com/mjs/q.epl?a=b?c=d
****
****
embperl parses this as:****
****
Using %fdat****
Field****
Value****
a b?c****
d****
****
CGI.pm parses this as:****
****
Using CGI.pm****
Field****
Value****
a****
b?c=d****
****
I agree that these are some pretty bizarre queries, but annoyingly we
can't change the source, and embperl seems to handle them pretty badly.
Googling suggests ? in a query string is probably valid, eg:****
****
http://www.456bereastreet.com/archive/201008/what_characters_are_allowed_unencoded_in_query_strings/
****
****
Is there anything that can be done to make embperl behave more as expected?
****
****
-- ****
Michael Stevens****
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB
Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com
The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988 ****
****
****
--
Michael Stevens****
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB
Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com
The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988 ****
****
** **
--
Michael Stevens****
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB
Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com
The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988 ****
--
Michael Stevens
Dianomi Ltd
18 Buckingham Gate
London SW1E 6LB

Tel: 020 3463 5662
Fax: 020 7630 7356
www.dianomi.com

The information in this message and any attachment is intended for the
addressee and is confidential and may be subject to legal privilege.
Dianomi Ltd, Registered Office: One America Square, Crosswall, London. EC3N
2SG. Registered in England and Wales with Company Registration Number
4513809. VAT registration number: 809754988
Loading...